Bug 215125 - Remove AudioSampleDataSource::setPaused
Summary: Remove AudioSampleDataSource::setPaused
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks: 215127
  Show dependency tree / graph
 
Reported: 2020-08-04 06:36 PDT by youenn fablet
Modified: 2020-08-04 09:02 PDT (History)
11 users (show)

See Also:

Attachments
Patch (3.46 KB, patch)
2020-08-04 06:39 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-08-04 06:36:44 PDT 
It is no longer used and can prevent m_transitioningFromPaused from being true
Comment 1 youenn fablet 2020-08-04 06:39:25 PDT 
Created attachment 405916 [details]
Patch
Comment 2 Geoffrey Garen 2020-08-04 08:55:31 PDT 
Comment on attachment 405916 [details]
Patch

r=me

Seems like m_transitioningFromPaused should be removed too?
Comment 3 youenn fablet 2020-08-04 08:58:59 PDT 
(In reply to Geoffrey Garen from comment #2)
> Comment on attachment 405916 [details]
> Patch
> 
> r=me
> 
> Seems like m_transitioningFromPaused should be removed too?

m_transitioningFromPaused is used to initialize the output sample timestamp offset.
I'll rename it in  https://bugs.webkit.org/show_bug.cgi?id=215127.
Comment 4 EWS 2020-08-04 09:01:30 PDT 
Committed r265244: <https://trac.webkit.org/changeset/265244>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405916 [details].
Comment 5 Radar WebKit Bug Importer 2020-08-04 09:02:22 PDT 
<rdar://problem/66525590>