Bug 215108 - [iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
Summary: [iOS Simulator] Assert under WebPage::platformDidReceiveLoadParameters
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-03 15:41 PDT by Per Arne Vollan
Modified: 2020-08-05 12:55 PDT (History)
5 users (show)

See Also:


Attachments
Patch (2.78 KB, patch)
2020-08-03 15:44 PDT, Per Arne Vollan
youennf: review+
Details | Formatted Diff | Diff
Patch (1.41 KB, patch)
2020-08-04 13:37 PDT, Per Arne Vollan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-08-03 15:41:47 PDT
On iOS Simulator, the following code asserts in WebPage::platformDidReceiveLoadParameters:

    bool databaseUpdated = LaunchServicesDatabaseManager::singleton().waitForDatabaseUpdate(5_s);
    ASSERT_UNUSED(databaseUpdated, databaseUpdated);
Comment 1 Per Arne Vollan 2020-08-03 15:44:53 PDT
Created attachment 405875 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-08-03 16:16:31 PDT
<rdar://problem/66496731>
Comment 3 youenn fablet 2020-08-04 05:08:54 PDT
Comment on attachment 405875 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405875&action=review

> Source/WebKit/ChangeLog:9
> +        com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Disable the entitlment check for simulator.

r=me but before landing, could you try (or maybe you did already) to add this entitlement to iOS simulator?
Looking at the code, I see XPCService-embedded-simulator.entitlements for instance where we could try adding that entitlement.
Comment 4 Per Arne Vollan 2020-08-04 13:37:48 PDT
Created attachment 405939 [details]
Patch
Comment 5 EWS 2020-08-04 14:03:18 PDT
Committed r265260: <https://trac.webkit.org/changeset/265260>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405939 [details].
Comment 6 Per Arne Vollan 2020-08-05 12:55:15 PDT
(In reply to youenn fablet from comment #3)
> Comment on attachment 405875 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405875&action=review
> 
> > Source/WebKit/ChangeLog:9
> > +        com.apple.private.webkit.use-xpc-endpoint on the iOS Simulator. Disable the entitlment check for simulator.
> 
> r=me but before landing, could you try (or maybe you did already) to add
> this entitlement to iOS simulator?
> Looking at the code, I see XPCService-embedded-simulator.entitlements for
> instance where we could try adding that entitlement.

Good point! That did the trick.

Thanks for reviewing!