Bug 215104 - Reduce use of 'aboutBlankURL().string()'
Summary: Reduce use of 'aboutBlankURL().string()'
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-08-03 15:34 PDT by Brent Fulgham
Modified: 2020-08-11 11:19 PDT (History)
18 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2020-08-03 15:34:26 PDT 
We should consider making a new immortal string representing "about:blank", like we do for empty string and some others, rather than converting from URL -> String for all of these cases.
Comment 1 Brent Fulgham 2020-08-03 17:18:02 PDT 
Created attachment 405890 [details]
Patch
Comment 2 Darin Adler 2020-08-04 14:42:11 PDT 
(In reply to Brent Fulgham from comment #0)
> We should consider making a new immortal string representing "about:blank",
> like we do for empty string and some others, rather than converting from URL
> -> String for all of these cases.

Why?
Comment 3 Darin Adler 2020-08-04 14:42:47 PDT 
"Converting" from URL to String is not really a thing. A URL has a String inside it so no conversion is required.
Comment 4 Darin Adler 2020-08-04 14:43:01 PDT 
I don’t think there is benefit here, but maybe I am missing something.
Comment 5 Radar WebKit Bug Importer 2020-08-10 15:35:16 PDT 
<rdar://problem/66803323>
Comment 6 Brent Fulgham 2020-08-11 11:19:05 PDT 
Closing based on Darin's comments.