WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED INVALID
215104
Reduce use of 'aboutBlankURL().string()'
https://bugs.webkit.org/show_bug.cgi?id=215104
Summary
Reduce use of 'aboutBlankURL().string()'
Brent Fulgham
Reported
2020-08-03 15:34:26 PDT
We should consider making a new immortal string representing "about:blank", like we do for empty string and some others, rather than converting from URL -> String for all of these cases.
Attachments
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2020-08-03 17:18:02 PDT
Created
attachment 405890
[details]
Patch
Darin Adler
Comment 2
2020-08-04 14:42:11 PDT
(In reply to Brent Fulgham from
comment #0
)
> We should consider making a new immortal string representing "about:blank", > like we do for empty string and some others, rather than converting from URL > -> String for all of these cases.
Why?
Darin Adler
Comment 3
2020-08-04 14:42:47 PDT
"Converting" from URL to String is not really a thing. A URL has a String inside it so no conversion is required.
Darin Adler
Comment 4
2020-08-04 14:43:01 PDT
I don’t think there is benefit here, but maybe I am missing something.
Radar WebKit Bug Importer
Comment 5
2020-08-10 15:35:16 PDT
<
rdar://problem/66803323
>
Brent Fulgham
Comment 6
2020-08-11 11:19:05 PDT
Closing based on Darin's comments.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug