Bug 215083 - Add constructor to DelayNode
Summary: Add constructor to DelayNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-08-03 09:00 PDT by Chris Dumez
Modified: 2020-08-03 16:24 PDT (History)
15 users (show)

See Also:

Attachments
Patch (43.38 KB, patch)
2020-08-03 11:05 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-08-03 09:00:46 PDT 
Add constructor to DelayNode:
- https://www.w3.org/TR/webaudio/#DelayNode
Comment 1 Chris Dumez 2020-08-03 11:05:48 PDT 
Created attachment 405851 [details]
Patch
Comment 2 Clark Wang 2020-08-03 11:34:43 PDT 
Comment on attachment 405851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review

> Source/WebCore/Modules/webaudio/DelayNode.h:36
> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);

I think DelayOptions parameter is optional, so should provide a default value.
Comment 3 Chris Dumez 2020-08-03 11:35:54 PDT 
Comment on attachment 405851 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405851&action=review

>> Source/WebCore/Modules/webaudio/DelayNode.h:36
>> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);
> 
> I think DelayOptions parameter is optional, so should provide a default value.

It is not necessary. Bindings are smart enough to always pass us a default-initialized dictionary.
Comment 4 Clark Wang 2020-08-03 11:43:39 PDT 
(In reply to Chris Dumez from comment #3)
> Comment on attachment 405851 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=405851&action=review
> 
> >> Source/WebCore/Modules/webaudio/DelayNode.h:36
> >> +    static ExceptionOr<Ref<DelayNode>> create(BaseAudioContext&, const DelayOptions&);
> > 
> > I think DelayOptions parameter is optional, so should provide a default value.
> 
> It is not necessary. Bindings are smart enough to always pass us a
> default-initialized dictionary.

Ah interesting, I'll take this into account for my future patches as well.
Comment 5 EWS 2020-08-03 14:49:46 PDT 
Committed r265221: <https://trac.webkit.org/changeset/265221>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405851 [details].
Comment 6 Radar WebKit Bug Importer 2020-08-03 16:24:50 PDT 
<rdar://problem/66497071>