Bug 215040 - Added Constructor to AnalyserNode
Summary: Added Constructor to AnalyserNode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Clark Wang
URL:
Keywords: InRadar
Depends on:
Blocks: 212611
  Show dependency tree / graph
 
Reported: 2020-07-31 15:54 PDT by Clark Wang
Modified: 2020-08-03 13:36 PDT (History)
13 users (show)

See Also:

Attachments
Patch (57.25 KB, patch)
2020-07-31 16:02 PDT, Clark Wang 		no flags Details | Formatted Diff | Diff
Patch (56.93 KB, patch)
2020-07-31 17:27 PDT, Clark Wang 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Clark Wang 2020-07-31 15:54:17 PDT 
Added constructor: https://www.w3.org/TR/webaudio/#AnalyserNode-constructors. Also added in AnalyserOptions.
Comment 1 Clark Wang 2020-07-31 16:02:12 PDT 
Created attachment 405754 [details]
Patch
Comment 2 Chris Dumez 2020-07-31 16:07:47 PDT 
roses are red, so are your EWS bubbles.
Comment 3 Chris Dumez 2020-07-31 16:12:48 PDT 
Comment on attachment 405754 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405754&action=review

> Source/WebCore/Modules/webaudio/AnalyserNode.cpp:124
> +    if (maxDecibels() && k >= maxDecibels())

0 dB seems like a valid value for decibels so why is it OK to bypass the security check for 0?
Comment 4 Clark Wang 2020-07-31 17:27:16 PDT 
Created attachment 405762 [details]
Patch
Comment 5 Clark Wang 2020-07-31 17:28:04 PDT 
(In reply to Chris Dumez from comment #2)
> roses are red, so are your EWS bubbles.

beautiful, thank you
Comment 6 Chris Dumez 2020-08-03 08:38:13 PDT 
Comment on attachment 405762 [details]
Patch

r=me
Comment 7 EWS 2020-08-03 08:51:46 PDT 
Committed r265196: <https://trac.webkit.org/changeset/265196>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405762 [details].
Comment 8 Radar WebKit Bug Importer 2020-08-03 13:36:07 PDT 
<rdar://problem/66489212>