Bug 215024 - Re-enable NO_SMT on Catalina
Summary: Re-enable NO_SMT on Catalina
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-31 11:10 PDT by Saam Barati
Modified: 2020-07-31 12:25 PDT (History)
6 users (show)

See Also:

Attachments
patch (2.22 KB, patch)
2020-07-31 11:26 PDT, Saam Barati 		ap: review+
Details | Formatted Diff | Diff
patch for landing (2.30 KB, patch)
2020-07-31 11:40 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-07-31 11:10:35 PDT 
...
Comment 1 Saam Barati 2020-07-31 11:26:39 PDT 
Created attachment 405713 [details]
patch
Comment 2 Alexey Proskuryakov 2020-07-31 11:32:14 PDT 
Comment on attachment 405713 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405713&action=review

> Source/JavaScriptCore/runtime/Options.cpp:235
> +#if CPU(X86_64) && (PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED < 110000)

I’m not sure what this does in macCatalyst case, or what we want it to do.
Comment 3 Saam Barati 2020-07-31 11:40:08 PDT 
Created attachment 405716 [details]
patch for landing
Comment 4 EWS 2020-07-31 12:24:14 PDT 
Committed r265154: <https://trac.webkit.org/changeset/265154>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405716 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-31 12:25:22 PDT 
<rdar://problem/66393176>