Bug 215002 - It would be nice if the predicate taking functions in ParsingUtilities.h didn't require specifying the character type
Summary: It would be nice if the predicate taking functions in ParsingUtilities.h didn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-30 19:19 PDT by Sam Weinig
Modified: 2020-07-30 20:49 PDT (History)
21 users (show)

See Also:

Attachments
Patch (34.30 KB, patch)
2020-07-30 19:34 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-07-30 19:19:26 PDT 
It would be nice if the predicate taking functions in ParsingUtilities.h didn't require specifying the character type. For example, instead of typing:

     skipUntil<CharacterType, isASCII>(buffer);

it would be nicer if we could write:

     skipUntil<isASCII>(buffer);
Comment 1 Sam Weinig 2020-07-30 19:34:08 PDT 
Created attachment 405652 [details]
Patch
Comment 2 EWS 2020-07-30 20:44:14 PDT 
Committed r265129: <https://trac.webkit.org/changeset/265129>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405652 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-30 20:45:21 PDT 
<rdar://problem/66362301>
Comment 4 Simon Fraser (smfr) 2020-07-30 20:49:00 PDT 
Wouldn't it be nice!