Bug 214951 - [webkitpy] Use webkitcorepy's auto installer for requests
Summary: [webkitpy] Use webkitcorepy's auto installer for requests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-29 17:26 PDT by Jonathan Bedard
Modified: 2020-08-12 16:10 PDT (History)
6 users (show)

See Also:

Attachments
Patch (9.04 KB, patch)
2020-07-29 21:29 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (9.09 KB, patch)
2020-07-29 21:40 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (9.84 KB, patch)
2020-07-30 07:17 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (9.87 KB, patch)
2020-07-30 21:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.93 KB, patch)
2020-08-04 16:02 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (8.08 KB, patch)
2020-08-04 16:27 PDT, Jonathan Bedard 		jbedard: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-07-29 17:26:45 PDT 
webkitcorepy has an auto-installed version of the requests library, we should be using that.
Comment 1 Radar WebKit Bug Importer 2020-07-29 20:46:42 PDT 
<rdar://problem/66308049>
Comment 2 Jonathan Bedard 2020-07-29 21:29:23 PDT 
Created attachment 405545 [details]
Patch
Comment 3 Jonathan Bedard 2020-07-29 21:34:38 PDT 
Comment on attachment 405545 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405545&action=review

> Tools/Scripts/webkitpy/thirdparty/__init__.py:86
> +            sys.path.insert(1 if 'libraries/autoinstalled' in sys.path[0] else 0, _AUTOINSTALLED_DIR)

Needed for compatibility. webkitpy cannot override webkitcorepy since webkitcorepy is, in some cases, uses more updated versions of the auto-installed libraries. We also don't want to require existing checkouts to delete their webkitpy auto install directory.
Comment 4 Jonathan Bedard 2020-07-29 21:40:41 PDT 
Created attachment 405546 [details]
Patch
Comment 5 Jonathan Bedard 2020-07-30 07:17:24 PDT 
Created attachment 405568 [details]
Patch
Comment 6 Jonathan Bedard 2020-07-30 21:01:26 PDT 
Created attachment 405659 [details]
Patch
Comment 7 Jonathan Bedard 2020-08-01 21:04:10 PDT 
Comment on attachment 405659 [details]
Patch

Blocking this on <https://bugs.webkit.org/show_bug.cgi?id=215067>, since that problem more correctly solves some of the issues this patch attempts to.
Comment 8 Jonathan Bedard 2020-08-04 16:02:14 PDT 
Created attachment 405954 [details]
Patch
Comment 9 Jonathan Bedard 2020-08-04 16:27:57 PDT 
Created attachment 405962 [details]
Patch
Comment 10 EWS 2020-08-12 16:10:14 PDT 
Committed r265574: <https://trac.webkit.org/changeset/265574>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405954 [details].