Bug 214925 - Make sure playback state constants remain on OscillatorNode for backward compatibility
Summary: Make sure playback state constants remain on OscillatorNode for backward comp...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Audio (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-29 10:53 PDT by Chris Dumez
Modified: 2020-07-29 12:13 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.78 KB, patch)
2020-07-29 10:54 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2020-07-29 10:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-29 10:53:30 PDT 
Make sure playback state constants remain on OscillatorNode for backward compatibility, while we keep supporting the prefixed Web Audio API.
Comment 1 Chris Dumez 2020-07-29 10:54:58 PDT 
Created attachment 405474 [details]
Patch
Comment 2 Eric Carlson 2020-07-29 10:57:05 PDT 
Comment on attachment 405474 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405474&action=review

> Source/WebCore/Modules/webaudio/OscillatorNode.idl:41
> +    // Legacy Playback state constants kept for backward compatibility with the prefixed API.

You may want to add a comment that these will be removed at some point.
Comment 3 Chris Dumez 2020-07-29 10:59:55 PDT 
Created attachment 405475 [details]
Patch
Comment 4 EWS 2020-07-29 12:12:51 PDT 
Committed r265050: <https://trac.webkit.org/changeset/265050>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405475 [details].
Comment 5 Radar WebKit Bug Importer 2020-07-29 12:13:18 PDT 
<rdar://problem/66285511>