Bug 214879 - [build.webkit.org] Add Big Sur builder
Summary: [build.webkit.org] Add Big Sur builder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-28 09:19 PDT by Jonathan Bedard
Modified: 2020-07-29 07:53 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.21 KB, patch)
2020-07-28 09:22 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.05 KB, patch)
2020-07-28 10:15 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (6.68 KB, patch)
2020-07-28 10:20 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (5.95 KB, patch)
2020-07-28 10:36 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (5.92 KB, patch)
2020-07-28 12:24 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2020-07-29 07:01 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-07-28 09:19:31 PDT 
We need to add a Big Sur Seed 3 builder to post-commit CI.
Comment 1 Radar WebKit Bug Importer 2020-07-28 09:19:49 PDT 
<rdar://problem/66221071>
Comment 2 Jonathan Bedard 2020-07-28 09:22:36 PDT 
Created attachment 405363 [details]
Patch
Comment 3 Jonathan Bedard 2020-07-28 10:15:07 PDT 
Created attachment 405371 [details]
Patch
Comment 4 Jonathan Bedard 2020-07-28 10:20:54 PDT 
Created attachment 405373 [details]
Patch
Comment 5 Jonathan Bedard 2020-07-28 10:36:21 PDT 
Created attachment 405376 [details]
Patch
Comment 6 Aakash Jain 2020-07-28 11:21:29 PDT 
Comment on attachment 405376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=405376&action=review

r+ with comments.

> Tools/ChangeLog:3
> +        [Big Sur] Add Seed 3 builder

A better bug title might be: [build.webkit.org] Add Big Sur builder.
The patch isn't specific to seed 3, 'seed 3' is a minor implementation detail.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:4
> +                    { "name": "bot279", "platform": "mac-bigsur"},

Might consider adding one more bot in the config right away, even if it would be ready after a while. One bot might not be enough for this queue.

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:109
> +                      "triggers": [],

triggers can be removed from here.
Comment 7 Jonathan Bedard 2020-07-28 12:24:26 PDT 
Created attachment 405392 [details]
Patch
Comment 8 Jonathan Bedard 2020-07-28 15:53:13 PDT 
Landed: https://trac.webkit.org/changeset/265016/webkit
Comment 9 EWS 2020-07-28 16:16:49 PDT 
Committed r265016: <https://trac.webkit.org/changeset/265016>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 405392 [details].
Comment 10 Aakash Jain 2020-07-28 17:31:09 PDT 
wkbuild.py might need update as well similar to https://trac.webkit.org/changeset/263300/webkit
Comment 11 Jonathan Bedard 2020-07-29 07:01:16 PDT 
Reopening to attach new patch.
Comment 12 Jonathan Bedard 2020-07-29 07:01:17 PDT 
Created attachment 405455 [details]
Patch
Comment 13 Jonathan Bedard 2020-07-29 07:51:49 PDT 
Committed r265040: <https://trac.webkit.org/changeset/265040>