[WPE] Make Touchpoint ID unique
Created attachment 405347 [details] Patch
Comment on attachment 405347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405347&action=review > Source/WebKit/ChangeLog:13 > + The web uses a unique touch point id. A few touch controllers reporting > + a unique ID by ABS_MT_TRACKING_ID [1] but libinput and the wayland-protocol > + don't take this information into account. Fix this within webkit to be > + independent of libinput, the wayland-protocol and a wayland-compositor. Can you please elaborate in more detail what failures in the libinput/wayland infrastructure this change tries to work around?
Comment on attachment 405347 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=405347&action=review >> Source/WebKit/ChangeLog:13 >> + independent of libinput, the wayland-protocol and a wayland-compositor. > > Can you please elaborate in more detail what failures in the libinput/wayland infrastructure this change tries to work around? As I wrote a few input event devices delivering a unique ID but this gets ignored by libinput and isn't covered by the wayland-protocol at all. Currently we are using the non unique touchpoint number to fill the web.touchpointID event. This is forbidden by the Spec if I got it correctly. You can see the different behavior if you call your test page: https://people.igalia.com/clopez/wkbug/pointer-events/test.html on an iOS-Port Safari browser or on an WPE-Port cog (embedded device with touch is required).
Ping
Updated version of the patch: https://github.com/WebKit/WebKit/pull/9599
Committed 263237@main (057b735cbf91): <https://commits.webkit.org/263237@main> Reviewed commits have been landed. Closing PR #9599 and removing active labels.