Bug 214823 - [ews] Make buildbot try robust against network issues
Summary: [ews] Make buildbot try robust against network issues
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-27 06:06 PDT by Aakash Jain
Modified: 2020-07-27 06:06 PDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-27 06:06:32 PDT
We should make 'buildbot try' commmand (run by ews django app to send patches to Buildbot) robust against network issues. For e.g. if Buildbot server is down for any reason (e.g: rebooting), any patches sent by ews django app (using buildbot try command) would be lost. This is because it isn't able to detect a failure in 'buildbot try' command. This is due to a bug in Buildbot (that the exit code of 'buildbot try' command is zero both in case of success and failure, see https://github.com/buildbot/buildbot/issues/4837).

We should improve the failure detection logic for Buildbot try command, and retry the command when it fails. This would make EWS Django app robust against network issues and buildbot restarts.
Comment 1 Radar WebKit Bug Importer 2020-07-27 06:06:58 PDT
<rdar://problem/66158707>