Bug 214762 - Remove unused WebGL 2.0-related methods
Summary: Remove unused WebGL 2.0-related methods
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 126404
  Show dependency tree / graph
 
Reported: 2020-07-24 14:49 PDT by Kenneth Russell
Modified: 2020-08-07 16:06 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-07-24 14:49:19 PDT 
Some methods in GraphicsContextGL and WebGL2RenderingContext exist only for the non-ANGLE code path. Since WebGL 2.0 is infeasible to implement without ANGLE, and has already been disabled for the non-ANGLE code path (!USE(ANGLE)), these methods and overrides should be removed.
Comment 1 Kenneth Russell 2020-07-24 14:50:45 PDT 
As one example, WebGLRenderingContextBase::validateIndexArrayConservative should be removed from the non-ANGLE code path, and the override removed from WebGL2RenderingContext.
Comment 2 Radar WebKit Bug Importer 2020-07-31 14:50:18 PDT 
<rdar://problem/66399743>
Comment 3 Kenneth Russell 2020-08-07 16:06:07 PDT 
After more thought, fixing up the remaining WebGL 2.0 conformance issues is higher priority than this cleanup. Downgrading to P3 and unassigning myself for the moment.