Bug 214540 - Use forward template declarations for ColorComponents instead of including ColorComponents.h
Summary: Use forward template declarations for ColorComponents instead of including Co...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-19 19:23 PDT by Fujii Hironori
Modified: 2020-07-20 01:38 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2020-07-19 19:29 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-07-19 19:23:35 PDT 
Use forward template declarations for ColorComponents instead of including ColorComponents.h

r264289 isn't a right fix.

(In reply to Darin Adler from bug #214204 comment #20)
> I’m not sure moving the include to the header was the best fix. We might
> have been able to just forward declare in the header and include only in the
> files that were using that template.
Comment 1 Fujii Hironori 2020-07-19 19:29:57 PDT 
Created attachment 404692 [details]
Patch
Comment 2 Darin Adler 2020-07-19 19:34:10 PDT 
Comment on attachment 404692 [details]
Patch

Let's wait for EWS results.
Comment 3 Fujii Hironori 2020-07-19 23:11:44 PDT 
Yup. All EWS are green. And, I confirmed WinCairo non-unified builds using Clang is fine.
Comment 4 Fujii Hironori 2020-07-20 01:37:30 PDT 
Comment on attachment 404692 [details]
Patch

Clearing flags on attachment: 404692

Committed r264593: <https://trac.webkit.org/changeset/264593>
Comment 5 Fujii Hironori 2020-07-20 01:37:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2020-07-20 01:38:17 PDT 
<rdar://problem/65813423>