Bug 214532 - AtomStringImpl should have more addWithStringTableProvider varieties, so Identifier can use them.
Summary: AtomStringImpl should have more addWithStringTableProvider varieties, so Iden...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-19 06:05 PDT by xc.o.c.1180@gmail.com
Modified: 2020-07-26 06:06 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description xc.o.c.1180@gmail.com 2020-07-19 06:05:04 PDT 
VM already has atomStringTable(), it is more efficient than looking it up.

Currently, there is only one addWithStringTableProvider(StringTableProvider& stringTableProvider, StringImpl* string).

There should be more, for example,
    WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const LChar*, unsigned length);
    WTF_EXPORT_PRIVATE static RefPtr<AtomStringImpl> add(const UChar*, unsigned length);

So, Ref<StringImpl> Identifier::add(VM& vm, const T* s, int length) can use them.
Comment 1 Radar WebKit Bug Importer 2020-07-26 06:06:16 PDT 
<rdar://problem/66125754>