Bug 214528 - Revert r262776 for existing apps using UIWebView/WebView
Summary: Revert r262776 for existing apps using UIWebView/WebView
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-18 21:54 PDT by Alex Christensen
Modified: 2020-07-20 17:53 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.43 KB, patch)
2020-07-18 21:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (4.88 KB, patch)
2020-07-20 09:49 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (12.50 KB, patch)
2020-07-20 16:24 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (8.23 KB, patch)
2020-07-20 16:36 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2020-07-18 21:54:47 PDT 
Revert r262776 for existing apps using UIWebView/WebView
Comment 1 Alex Christensen 2020-07-18 21:59:02 PDT 
Created attachment 404654 [details]
Patch
Comment 2 Alex Christensen 2020-07-18 21:59:05 PDT 
<rdar://problem/65468982>
Comment 3 Tim Horton 2020-07-18 23:47:26 PDT 
Comment on attachment 404654 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404654&action=review

What's the deal with the failing tests?

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:117
> +static bool shouldAddPostContentTypeIfUnspecified()

Weird, did not realize VersionChecks.h was in WebKit2. OK!
Comment 4 Alex Christensen 2020-07-20 09:49:21 PDT 
Created attachment 404723 [details]
Patch
Comment 5 Alex Christensen 2020-07-20 16:24:52 PDT 
Created attachment 404776 [details]
Patch
Comment 6 Alex Christensen 2020-07-20 16:36:01 PDT 
Created attachment 404777 [details]
Patch
Comment 7 EWS 2020-07-20 17:53:50 PDT 
Committed r264642: <https://trac.webkit.org/changeset/264642>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404777 [details].