Bug 214481 - REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes
Summary: REGRESSION(r264486): storage/indexeddb/structured-clone.html crashes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
: 214450 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-07-17 09:37 PDT by Sihui Liu
Modified: 2020-07-18 11:17 PDT (History)
10 users (show)

See Also:

Attachments
Patch (6.01 KB, patch)
2020-07-17 09:51 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (1.41 KB, patch)
2020-07-17 15:47 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
skip the tests (1.47 KB, patch)
2020-07-17 16:00 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Sihui Liu 2020-07-17 09:51:28 PDT 
Created attachment 404568 [details]
Patch
Comment 2 Truitt Savell 2020-07-17 10:18:52 PDT 
*** Bug 214450 has been marked as a duplicate of this bug. ***
Comment 3 EWS 2020-07-17 11:34:51 PDT 
Committed r264524: <https://trac.webkit.org/changeset/264524>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404568 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-17 11:35:15 PDT 
<rdar://problem/65735839>
Comment 6 Truitt Savell 2020-07-17 14:02:27 PDT 
(In reply to Truitt Savell from comment #5)
> These two tests started failing on windows at the same time, after the
> changes in 264524 they are not timing out:
> https://results.webkit.org/?suite=layout-tests&suite=layout-
> tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation.
> svg&test=storage%2Findexeddb%2Fstructured-clone-private.
> html&test=storage%2Findexeddb%2Fstructured-clone.html

They are *now* timing out
Comment 7 Sihui Liu 2020-07-17 15:45:48 PDT 
(In reply to Truitt Savell from comment #6)
> (In reply to Truitt Savell from comment #5)
> > These two tests started failing on windows at the same time, after the
> > changes in 264524 they are not timing out:
> > https://results.webkit.org/?suite=layout-tests&suite=layout-
> > tests&suite=layout-tests&test=imported%2Fmozilla%2Fsvg%2Fblend-saturation.
> > svg&test=storage%2Findexeddb%2Fstructured-clone-private.
> > html&test=storage%2Findexeddb%2Fstructured-clone.html
> 
> They are *now* timing out

These two tests were skipped and now they can run on platforms other than windows. I will keep the test expectation on win to Skip and let the tests run other platforms.
Comment 8 Sihui Liu 2020-07-17 15:47:44 PDT 
Created attachment 404612 [details]
Patch for landing
Comment 9 EWS 2020-07-17 15:57:25 PDT 
Tools/Scripts/svn-apply failed to apply attachment 404612 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Sihui Liu 2020-07-17 16:00:14 PDT 
Created attachment 404614 [details]
skip the tests
Comment 11 EWS 2020-07-17 16:52:29 PDT 
Committed r264557: <https://trac.webkit.org/changeset/264557>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404614 [details].
Comment 12 Alexey Proskuryakov 2020-07-18 11:08:45 PDT 
# Fatal error in: /Volumes/Data/slave/catalina-debug/build/Source/ThirdParty/libwebrtc/Source/webrtc/rtc_base/rtc_certificate_generator.cc, line 147
# last system error: 2
# Check failed: signaling_thread_->IsCurrent()


Doesn't look like anything was fixed yet, so re-opening.
Comment 13 Alexey Proskuryakov 2020-07-18 11:16:50 PDT 
Actually, there WAS a fix, it was just marked as obsolete patch.