Bug 214372 - [ews] clicking submit for EWS analysis button for patches on closed bug should display error
Summary: [ews] clicking submit for EWS analysis button for patches on closed bug shoul...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 13:22 PDT by Aakash Jain
Modified: 2020-07-15 14:42 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.42 KB, patch)
2020-07-15 13:27 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-15 13:22:09 PDT 
Clicking 'submit for EWS analysis' button for patches on closed bug should display error, and such patches shouldn't be sent to EWS (buildbot). This is because the first thing our Buildbot builders do is to validate-patch, which will skip the patch if the corresponding bug is closed. Therefore sending the patch to Buildbot is useless, and might be confusing for users.

It's better to display an error that the patch is not being sent to EWS since the corresponding bug is already closed.
Comment 1 Aakash Jain 2020-07-15 13:27:24 PDT 
Created attachment 404384 [details]
Patch
Comment 2 Aakash Jain 2020-07-15 13:28:30 PDT 
Tested in https://ews.webkit-uat.org/status-bubble/404379 (feel free to click the button to check the new behavior)
Comment 3 EWS 2020-07-15 14:18:06 PDT 
Committed r264421: <https://trac.webkit.org/changeset/264421>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404384 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-15 14:19:18 PDT 
<rdar://problem/65626564>
Comment 5 Aakash Jain 2020-07-15 14:42:45 PDT 
> Committed r264421: <https://trac.webkit.org/changeset/264421>
Deployed it on the server.