Bug 214351 - Make ews django app robust against network issues
Summary: Make ews django app robust against network issues
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-15 07:16 PDT by Aakash Jain
Modified: 2020-07-15 07:52 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2020-07-15 07:20 PDT, Aakash Jain
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-15 07:16:52 PDT
Make ews django app robust against buildbot downtime. When ews django app starts, it fetches builder_name_to_id_mapping from Buildbot server. It fetches it only once. If Buildbot server was down at that moment or there was any network issue, that mapping isn't fetched. This mapping is used to decide which patches to send to Commit-Queue (by fetching list of pending_and_inprogress_builds on commit-queue). Although failure to fetch this mapping doesn't cause any functionality issue, since the logic is able to work without this mapping as well, it becomes little inefficient and logs have error messages like: "Invalid builder: Commit-Queue".

We should re-fetch this mapping when required to make ews django app more robust against Buildbot downtime or network issues.
Comment 1 Aakash Jain 2020-07-15 07:20:30 PDT
Created attachment 404340 [details]
Patch
Comment 2 EWS 2020-07-15 07:51:40 PDT
Committed r264398: <https://trac.webkit.org/changeset/264398>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404340 [details].
Comment 3 Radar WebKit Bug Importer 2020-07-15 07:52:15 PDT
<rdar://problem/65605376>