Bug 214332 - We must hold the CodeBlock lock when calling StructureStubInfo::reset
Summary: We must hold the CodeBlock lock when calling StructureStubInfo::reset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-14 16:44 PDT by Saam Barati
Modified: 2020-07-14 22:54 PDT (History)
15 users (show)

See Also:

Attachments
patch (15.35 KB, patch)
2020-07-14 16:54 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-07-14 16:44:51 PDT 
...
Comment 1 Saam Barati 2020-07-14 16:45:32 PDT 
<rdar://problem/64940787>
Comment 2 Saam Barati 2020-07-14 16:54:18 PDT 
Created attachment 404307 [details]
patch
Comment 3 Yusuke Suzuki 2020-07-14 16:56:35 PDT 
Comment on attachment 404307 [details]
patch

r=me
Comment 4 Saam Barati 2020-07-14 16:57:28 PDT 
Comment on attachment 404307 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=404307&action=review

> Source/JavaScriptCore/jit/Repatch.cpp:148
> +        {
> +            GCSafeConcurrentJSLocker locker(codeBlock->m_lock, vm.heap);
> +            stubInfo.reset(locker, codeBlock);
> +        }

this is the bug fix
Comment 5 EWS 2020-07-14 22:54:50 PDT 
Committed r264388: <https://trac.webkit.org/changeset/264388>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404307 [details].