Bug 214301 - WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken after r264335
Summary: WPT test css/css-grid/grid-definition/grid-auto-fit-columns-001.html broken a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-14 05:42 PDT by Carlos Alberto Lopez Perez
Modified: 2020-07-14 08:33 PDT (History)
7 users (show)

See Also:

Attachments
Patch (34.25 KB, patch)
2020-07-14 05:53 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (35.14 KB, patch)
2020-07-14 06:01 PDT, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2020-07-14 05:42:32 PDT 
r264335 updated the imported css-grid WPT tests.
The update contains a change (base href) for the test imported/w3c/web-platform-tests/css/css-grid/grid-definition/grid-auto-fit-columns-001.html that breaks it.
Comment 1 Carlos Alberto Lopez Perez 2020-07-14 05:53:06 PDT 
Created attachment 404226 [details]
Patch
Comment 2 EWS Watchlist 2020-07-14 05:54:22 PDT 
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment 3 Carlos Alberto Lopez Perez 2020-07-14 05:56:30 PDT 
Ok.. I just noticed this has been fixed on WPT 4b5101fabe653a57921f6e7add9ff768027206fa
Comment 4 Carlos Alberto Lopez Perez 2020-07-14 06:01:45 PDT 
Created attachment 404227 [details]
Patch

Import commit 4b5101fabe from WPT and update expectations
Comment 5 Manuel Rego Casasnovas 2020-07-14 06:03:50 PDT 
Comment on attachment 404227 [details]
Patch

r=me
Comment 6 EWS 2020-07-14 08:32:55 PDT 
Committed r264339: <https://trac.webkit.org/changeset/264339>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404227 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-14 08:33:15 PDT 
<rdar://problem/65544302>