Bug 214164 - Resync web-platform-tests/media-source from upstream
Summary: Resync web-platform-tests/media-source from upstream
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 213927
  Show dependency tree / graph
 
Reported: 2020-07-09 15:44 PDT by Chris Dumez
Modified: 2020-07-16 09:04 PDT (History)
13 users (show)

See Also:

Attachments
Patch (157.29 KB, patch)
2020-07-09 16:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (166.48 KB, patch)
2020-07-10 08:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (165.48 KB, patch)
2020-07-10 12:43 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (165.06 KB, patch)
2020-07-14 08:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-07-09 15:44:23 PDT 
Resync web-platform-tests/media-source from upstream.
Comment 1 Chris Dumez 2020-07-09 16:21:06 PDT 
Created attachment 403928 [details]
Patch
Comment 2 Chris Dumez 2020-07-10 08:56:59 PDT 
Created attachment 403970 [details]
Patch
Comment 3 Geoffrey Garen 2020-07-10 12:26:29 PDT 
Seems like there's a WK1 EWS failure.
Comment 4 Chris Dumez 2020-07-10 12:28:56 PDT 
Comment on attachment 403970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403970&action=review

> LayoutTests/TestExpectations:308
> +webkit.org/b/214166 imported/w3c/web-platform-tests/media-source/idlharness.window.html [ Skip ]

Yes, the test is crashing and I skipped it here. Not sure why the test is still running.
Comment 5 Chris Dumez 2020-07-10 12:43:31 PDT 
Created attachment 403992 [details]
Patch
Comment 6 Chris Dumez 2020-07-10 15:06:36 PDT 
Comment on attachment 403992 [details]
Patch

All green, patch is ready.
Comment 7 Chris Dumez 2020-07-13 08:37:51 PDT 
Ping. Patch is ready for review.
Comment 8 Geoffrey Garen 2020-07-14 08:53:18 PDT 
Comment on attachment 403992 [details]
Patch

rs=me
Comment 9 EWS 2020-07-14 08:53:57 PDT 
Tools/Scripts/svn-apply failed to apply attachment 403992 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 10 Chris Dumez 2020-07-14 08:56:22 PDT 
Created attachment 404240 [details]
Patch
Comment 11 EWS 2020-07-14 09:40:49 PDT 
Committed r264345: <https://trac.webkit.org/changeset/264345>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 404240 [details].
Comment 12 Radar WebKit Bug Importer 2020-07-14 09:41:16 PDT 
<rdar://problem/65547775>