Bug 214147 - Add EWS queues for tvOS and watchOS builders
Summary: Add EWS queues for tvOS and watchOS builders
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-09 10:25 PDT by Aakash Jain
Modified: 2020-07-13 18:00 PDT (History)
8 users (show)

See Also:

Attachments
Patch (12.68 KB, patch)
2020-07-09 10:36 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Aakash Jain 2020-07-09 10:25:47 PDT 
Add EWS queues for tvOS and watchOS. It would prevent people from accidentally breaking these configurations.
Comment 1 Aakash Jain 2020-07-09 10:36:44 PDT 
Created attachment 403886 [details]
Patch
Comment 2 Ryan Haddad 2020-07-09 11:54:47 PDT 
Comment on attachment 403886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403886&action=review

> Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46
> +    ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win',

I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'.
Comment 3 Aakash Jain 2020-07-09 12:19:18 PDT 
(In reply to Ryan Haddad from comment #2)
> > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46
> > +    ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win',
> 
> I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'.
These names appear in status-bubbles on Bugzilla, so I was trying to keep them small (similar to 'mac' instead of 'macos').
Comment 4 Ryan Haddad 2020-07-09 12:24:55 PDT 
(In reply to Aakash Jain from comment #3)
> (In reply to Ryan Haddad from comment #2)
> > > Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py:46
> > > +    ALL_QUEUES = ['style', 'ios', 'ios-sim', 'mac', 'mac-debug', 'tv', 'tv-sim', 'watch', 'watch-sim', 'gtk', 'wpe', 'wincairo', 'win',
> > 
> > I think we should use 'tvos' and 'watchos' instead of 'tv' and 'watch'.
> These names appear in status-bubbles on Bugzilla, so I was trying to keep
> them small (similar to 'mac' instead of 'macos').
If keeping the bubbles small is a priority, that's fine.
Comment 5 Dean Johnson 2020-07-09 13:23:07 PDT 
Comment on attachment 403886 [details]
Patch

Unofficial r=me. Code looks good.
Comment 6 EWS 2020-07-09 14:23:52 PDT 
Committed r264196: <https://trac.webkit.org/changeset/264196>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403886 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-09 14:24:16 PDT 
<rdar://problem/65290635>
Comment 8 Aakash Jain 2020-07-13 18:00:02 PDT 
Minor follow-up fix: https://trac.webkit.org/changeset/264327/webkit