Bug 214144 - Simplify BoxPtr::create
Summary: Simplify BoxPtr::create
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Xabier Rodríguez Calvar
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-09 09:24 PDT by Xabier Rodríguez Calvar
Modified: 2020-07-09 10:34 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.05 KB, patch)
2020-07-09 09:28 PDT, Xabier Rodríguez Calvar 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Xabier Rodríguez Calvar 2020-07-09 09:24:00 PDT 
Fix what Darin commented on comment 29 of bug 212379
Comment 1 Xabier Rodríguez Calvar 2020-07-09 09:28:43 PDT 
Created attachment 403875 [details]
Patch
Comment 2 Darin Adler 2020-07-09 09:55:22 PDT 
Comment on attachment 403875 [details]
Patch

I also think that create is not the right word for something that takes ownership of an object. Maybe we need to rename those create functions to adopt.
Comment 3 EWS 2020-07-09 10:34:00 PDT 
Committed r264180: <https://trac.webkit.org/changeset/264180>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403875 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-09 10:34:16 PDT 
<rdar://problem/65278265>