Bug 214104 - Remove glBindFramebuffer flush workaround from ANGLE
Summary: Remove glBindFramebuffer flush workaround from ANGLE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords: InRadar
Depends on: 206625
Blocks:
  Show dependency tree / graph
 
Reported: 2020-07-08 16:01 PDT by Kenneth Russell
Modified: 2020-07-10 13:25 PDT (History)
7 users (show)

See Also:

Attachments
Patch (3.74 KB, patch)
2020-07-09 19:11 PDT, Kenneth Russell 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2020-07-08 16:01:07 PDT 
In Bug 206625 a workaround was added to WebKit's snapshot of ANGLE to flush around calls to glBindFramebuffer on Intel GPUs as a potential way to address flakiness seen in layout tests after switching to the ANGLE backend.

However, it's very likely that jdarpinian@'s fix for Bug 208724, setting the EGL_ROBUST_RESOURCE_INITIALIZATION_ANGLE context creation attribute to true, fixed the underlying root cause.

The glBindFramebuffer flush workaround persists in WebKit's ANGLE snapshot, and should be removed as it's very likely unnecessary.
Comment 1 Kenneth Russell 2020-07-09 19:11:39 PDT 
Created attachment 403940 [details]
Patch
Comment 2 EWS Watchlist 2020-07-09 19:12:16 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 EWS 2020-07-10 13:24:55 PDT 
Committed r264238: <https://trac.webkit.org/changeset/264238>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403940 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-10 13:25:13 PDT 
<rdar://problem/65360176>