Bug 214091 - [PlayStation] Build fix after r264050
Summary: [PlayStation] Build fix after r264050
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Stephan Szabo
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-08 10:59 PDT by Stephan Szabo
Modified: 2020-07-08 11:42 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.45 KB, patch)
2020-07-08 11:02 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff
Patch (1.45 KB, patch)
2020-07-08 11:12 PDT, Stephan Szabo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stephan Szabo 2020-07-08 10:59:48 PDT
SimpleColor change required a change to playstation specific file.

Wanted to land it as buildfix, but webkit-patch seems to be unhappy on my local.
Comment 1 Stephan Szabo 2020-07-08 11:02:07 PDT
Created attachment 403794 [details]
Patch
Comment 2 Stephan Szabo 2020-07-08 11:12:39 PDT
Created attachment 403796 [details]
Patch
Comment 3 EWS 2020-07-08 11:39:27 PDT
Committed r264121: <https://trac.webkit.org/changeset/264121>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403796 [details].
Comment 4 Radar WebKit Bug Importer 2020-07-08 11:40:18 PDT
<rdar://problem/65233866>
Comment 5 Darin Adler 2020-07-08 11:42:56 PDT
Comment on attachment 403796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403796&action=review

> Source/WebCore/platform/playstation/ScrollbarThemePlayStation.cpp:78
> +    context.fillRect(trackRect, scrollbar.enabled() ? Color::lightGray : Color(makeSimpleColor(0xE0, 0xE0, 0xE0)));

Don’t need the Color() here.