WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
214086
[MSE][GStreamer] Remove orphan code in SourceBufferPrivateGStreamer::append()
https://bugs.webkit.org/show_bug.cgi?id=214086
Summary
[MSE][GStreamer] Remove orphan code in SourceBufferPrivateGStreamer::append()
Alicia Boya García
Reported
2020-07-08 09:04:11 PDT
A refactor in
r240784
missed this line, which was unreachable code before and should have removed. Instead, it has been run every time after sending an append to the AppendPipeline, and it just happens it doesn't have visible consequences. This patch cleans that up removing that line. No visible behavior changes are introduces.
Attachments
Patch
(1.87 KB, patch)
2020-07-08 09:05 PDT
,
Alicia Boya García
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alicia Boya García
Comment 1
2020-07-08 09:05:19 PDT
Created
attachment 403786
[details]
Patch
Enrique Ocaña
Comment 2
2020-07-08 09:23:57 PDT
I agree with this patch. The changes on
r240784
made AppendPipeline::pushNewBuffer() unable to return any error for early append failure. Therefore the call to sourceBufferPrivateAppendComplete() (which should happend only in case of error) wouldn't be needed anymore.
EWS
Comment 3
2020-07-09 01:29:39 PDT
Committed
r264161
: <
https://trac.webkit.org/changeset/264161
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 403786
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug