Bug 214032 - Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()
Summary: Function didCleanupFullscreencreen() should be called at the end of VideoFull...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Peng Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-07-06 21:06 PDT by Peng Liu
Modified: 2020-07-07 11:03 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.00 KB, patch)
2020-07-06 21:12 PDT, Peng Liu 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peng Liu 2020-07-06 21:06:04 PDT 
Function didCleanupFullscreencreen() should be called at the end of VideoFullscreenInterfaceAVKit::cleanupFullscreen()
Comment 1 Peng Liu 2020-07-06 21:08:36 PDT 
<rdar://problem/65041486>
Comment 2 Peng Liu 2020-07-06 21:12:38 PDT 
Created attachment 403663 [details]
Patch
Comment 3 Eric Carlson 2020-07-07 09:46:29 PDT 
Comment on attachment 403663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review

> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987
>      [playerController() setHasEnabledVideo:false];
>      [playerController() setHasVideo:false];

Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup.
Comment 4 Peng Liu 2020-07-07 10:50:39 PDT 
Comment on attachment 403663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403663&action=review

>> Source/WebCore/platform/ios/VideoFullscreenInterfaceAVKit.mm:987
>>      [playerController() setHasVideo:false];
> 
> Doesn't seem like we should have to call both of these, shouldn't setting `hasVideo` to false automatically set `hasEnabledVideo` to false? Not new to this patch, but it would be good to change this in a future cleanup.

Right! We need to update WebAVPlayerController to do that.
Comment 5 EWS 2020-07-07 11:03:20 PDT 
Committed r264030: <https://trac.webkit.org/changeset/264030>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403663 [details].