Bug 213936 - WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD
Summary: WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks: 212420
  Show dependency tree / graph
 
Reported: 2020-07-03 13:23 PDT by Darin Adler
Modified: 2020-07-03 14:56 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.83 KB, patch)
2020-07-03 13:24 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (3.37 KB, patch)
2020-07-03 13:53 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-07-03 13:23:28 PDT 
WebCore/Sources.txt: Remove #if ENABLE_GAMEPAD
Comment 1 Darin Adler 2020-07-03 13:24:29 PDT 
Created attachment 403475 [details]
Patch
Comment 2 Darin Adler 2020-07-03 13:29:00 PDT 
Comment on attachment 403475 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=403475&action=review

> Source/WebCore/ChangeLog:8
> +        * Sources.txt: Remove #if ENABLE_APPLICATION_MANIFEST and sort files in with the others.

Oops, this should say ENABLE_GAMEPAD.
Comment 3 Darin Adler 2020-07-03 13:45:10 PDT 
Looks like I need to modify something so the empty source files get generated, since I am getting this error in the GTK build:

Cannot find source file:
    /app/webkit/WebKitBuild/Release/DerivedSources/WebCore/JSGamepad.cpp

Maybe the perl scripts need to be changed so they generate an empty file rather than no file at all. Or perhaps a file with a comment "/* This file intentionally left empty. */" in it?
Comment 4 Darin Adler 2020-07-03 13:47:27 PDT 
Hmm, no it seems the real problem is that this same error is repeated in the CMake files, where we conditionalize compilation there instead of in the code. I will make the same change to CMake, I guess. That's going to make this more of a pain, but I think it's the right thing to do.
Comment 5 Darin Adler 2020-07-03 13:53:25 PDT 
Created attachment 403482 [details]
Patch
Comment 6 EWS 2020-07-03 14:44:04 PDT 
Committed r263910: <https://trac.webkit.org/changeset/263910>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403482 [details].
Comment 7 Radar WebKit Bug Importer 2020-07-03 14:45:16 PDT 
<rdar://problem/65083720>