GameController.framework soft linking refactoring We'll soon need to use GC.framework in multiple places, so it's time to refactor it out into its own files. (Also add a soon-to-be-needed SPI header while I'm at it)
Created attachment 403420 [details] Patch
Comment on attachment 403420 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=403420&action=review > Source/WebCore/platform/gamepad/cocoa/GameControllerSPI.h:33 > +WTF_EXTERN_C_BEGIN This should include a fixme with a radar where you ask for the headers to be fixed. > Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:33 > +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, GameController) I think you lost the optionality here?
(In reply to Tim Horton from comment #2) > Comment on attachment 403420 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=403420&action=review > > > Source/WebCore/platform/gamepad/cocoa/GameControllerSPI.h:33 > > +WTF_EXTERN_C_BEGIN > > This should include a fixme with a radar where you ask for the headers to be > fixed. Sure. > > > Source/WebCore/platform/gamepad/cocoa/GameControllerSoftLink.mm:33 > > +SOFT_LINK_FRAMEWORK_FOR_SOURCE(WebCore, GameController) > > I think you lost the optionality here? Actually not - Using the Header/Source softlink for a Framework always has optionality. (You'll see that used in the next patch!
Created attachment 403422 [details] Patch for landing
Committed r263878: <https://trac.webkit.org/changeset/263878> All reviewed patches have been landed. Closing bug and clearing flags on attachment 403422 [details].
<rdar://problem/65058543>