Bug 213769 - [TestExpectations] Add architecture for Apple's ports
Summary: [TestExpectations] Add architecture for Apple's ports
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-29 19:50 PDT by Jonathan Bedard
Modified: 2020-06-30 07:48 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.35 KB, patch)
2020-06-29 20:18 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (1.35 KB, patch)
2020-06-30 07:28 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-29 19:50:06 PDT 
Apple's ports need to support architecture modifiers in test expectations, this is particularly important for for supporting Apple Silicon.
Comment 1 Radar WebKit Bug Importer 2020-06-29 19:54:50 PDT 
<rdar://problem/64920013>
Comment 2 Jonathan Bedard 2020-06-29 20:18:45 PDT 
Created attachment 403166 [details]
Patch
Comment 3 Jonathan Bedard 2020-06-29 20:19:56 PDT 
Turns out, we already have support for this. We should still refactor our test expectation parser, it's far more complicated than it needs to be.
Comment 4 Aakash Jain 2020-06-30 07:14:53 PDT 
rs=me
Comment 5 Jonathan Bedard 2020-06-30 07:28:19 PDT 
Created attachment 403197 [details]
Patch for landing
Comment 6 EWS 2020-06-30 07:48:43 PDT 
Committed r263749: <https://trac.webkit.org/changeset/263749>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 403197 [details].