Bug 213639 - [Big Sur] Handle baseline search path
Summary: [Big Sur] Handle baseline search path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryan Haddad
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-25 21:28 PDT by Ryan Haddad
Modified: 2020-06-26 14:11 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2020-06-25 21:48 PDT, Ryan Haddad 		no flags Details | Formatted Diff | Diff
Patch (3.39 KB, patch)
2020-06-26 08:46 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch (3.38 KB, patch)
2020-06-26 08:51 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Patch for landing (3.38 KB, patch)
2020-06-26 09:08 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Haddad 2020-06-25 21:28:42 PDT 
[Big Sur] Regression tests fail to run due to failed assert: self._os_version.major == 10
Comment 1 Ryan Haddad 2020-06-25 21:29:40 PDT 
<rdar://problem/64789480>
Comment 2 Ryan Haddad 2020-06-25 21:48:37 PDT 
Created attachment 402850 [details]
Patch
Comment 3 EWS 2020-06-25 22:20:37 PDT 
Committed r263553: <https://trac.webkit.org/changeset/263553>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402850 [details].
Comment 4 Jonathan Bedard 2020-06-26 08:46:51 PDT 
Reopening to attach new patch.
Comment 5 Jonathan Bedard 2020-06-26 08:46:52 PDT 
Created attachment 402869 [details]
Patch
Comment 6 Jonathan Bedard 2020-06-26 08:51:37 PDT 
Created attachment 402870 [details]
Patch
Comment 7 Aakash Jain 2020-06-26 09:04:17 PDT 
Comment on attachment 402870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402870&action=review

rs=me

> Tools/Scripts/webkitpy/port/mac.py:86
> +                        temp_version = Version(11)

Should it be explicitly: Version(11, 0)

or better yet:
temp_version.major += 1
temp_version.minor = 0
Comment 8 Jonathan Bedard 2020-06-26 09:08:53 PDT 
Created attachment 402871 [details]
Patch for landing
Comment 9 EWS 2020-06-26 09:32:00 PDT 
Committed r263561: <https://trac.webkit.org/changeset/263561>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402871 [details].
Comment 10 Jonathan Bedard 2020-06-26 14:11:55 PDT 
Committed r263583: <https://trac.webkit.org/changeset/263583>