Bug 213585 - Running spellcheck on https://developer.apple.com/forums/thread/650317 hangs the web process
Summary: Running spellcheck on https://developer.apple.com/forums/thread/650317 hangs ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-24 17:49 PDT by Wenson Hsieh
Modified: 2020-06-24 21:42 PDT (History)
10 users (show)

See Also:

Attachments
Patch (7.34 KB, patch)
2020-06-24 18:05 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Fix IOS_FAMILY build (7.30 KB, patch)
2020-06-24 18:15 PDT, Wenson Hsieh 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-06-24 17:49:54 PDT 
Steps (macOS):
1. Load https://developer.apple.com/forums/thread/650317
2. Click "Reply to this question"
   (Sign in with an Apple ID if needed)
4. Focus the comment box
5. Press CMD+; to trigger spellchecking.

The web content process hangs indefinitely as a result.
Comment 1 Wenson Hsieh 2020-06-24 17:56:30 PDT 
<rdar://problem/64681632>
Comment 2 Wenson Hsieh 2020-06-24 18:05:50 PDT Comment hidden (obsolete)
Comment 3 Darin Adler 2020-06-24 18:08:33 PDT 
Comment on attachment 402703 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402703&action=review

> Source/WebCore/testing/Internals.idl:383
> +    void advanceToNextMisspelling();

How can this be unconditional if the declaration in the .h file is inside an #if?
Comment 4 Wenson Hsieh 2020-06-24 18:10:16 PDT 
(In reply to Darin Adler from comment #3)
> Comment on attachment 402703 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402703&action=review
> 
> > Source/WebCore/testing/Internals.idl:383
> > +    void advanceToNextMisspelling();
> 
> How can this be unconditional if the declaration in the .h file is inside an
> #if?

Indeed, this breaks the IOS_FAMILY build 😅. Trying to fix it now.
Comment 5 Wenson Hsieh 2020-06-24 18:15:50 PDT 
Created attachment 402705 [details]
Fix IOS_FAMILY build
Comment 6 Wenson Hsieh 2020-06-24 21:29:02 PDT 
Comment on attachment 402705 [details]
Fix IOS_FAMILY build

Thanks for the review!
Comment 7 EWS 2020-06-24 21:42:16 PDT 
Committed r263499: <https://trac.webkit.org/changeset/263499>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402705 [details].