Bug 213489 - Remove WKkIsTranslated once our bots are updated to the needed SDK
Summary: Remove WKkIsTranslated once our bots are updated to the needed SDK
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-22 15:23 PDT by Saam Barati
Modified: 2020-06-23 13:12 PDT (History)
7 users (show)

See Also:

Attachments
patch (7.07 KB, patch)
2020-06-23 11:09 PDT, Saam Barati 		thorton: review+
Details | Formatted Diff | Diff
patch for landing (7.04 KB, patch)
2020-06-23 11:15 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-22 15:23:02 PDT 
...
Comment 1 mitz 2020-06-22 15:47:15 PDT 
Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using the oah_is_current_process_translated SPI.
Comment 2 Saam Barati 2020-06-22 16:32:53 PDT 
(In reply to mitz from comment #1)
> Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using
> the oah_is_current_process_translated SPI.

Will do
Comment 3 mitz 2020-06-23 08:53:33 PDT 
(In reply to Saam Barati from comment #2)
> (In reply to mitz from comment #1)
> > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using
> > the oah_is_current_process_translated SPI.
> 
> Will do

Better yet, use the public sysctl interface documented at <https://developer.apple.com/documentation/apple_silicon/about_the_rosetta_translation_environment>.
Comment 4 Saam Barati 2020-06-23 10:18:52 PDT 
(In reply to mitz from comment #3)
> (In reply to Saam Barati from comment #2)
> > (In reply to mitz from comment #1)
> > > Rather than using _COMM_PAGE_CPU_CAPABILITIES64, you should consider using
> > > the oah_is_current_process_translated SPI.
> > 
> > Will do
> 
> Better yet, use the public sysctl interface documented at
> <https://developer.apple.com/documentation/apple_silicon/
> about_the_rosetta_translation_environment>.

👍🏼
Comment 5 Saam Barati 2020-06-23 10:21:19 PDT 
I think we can just make this change now if we're using the sysctl
Comment 6 Saam Barati 2020-06-23 11:09:58 PDT 
Created attachment 402571 [details]
patch
Comment 7 Saam Barati 2020-06-23 11:11:46 PDT 
Comment on attachment 402571 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review

> Source/WTF/wtf/TranslatedProcess.cpp:33
> +#include <wtf/DataLog.h>

will remove
Comment 8 Tim Horton 2020-06-23 11:12:04 PDT 
Comment on attachment 402571 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=402571&action=review

> Source/WTF/wtf/TranslatedProcess.cpp:33
> +#include <wtf/DataLog.h>

Why's this?
Comment 9 Saam Barati 2020-06-23 11:12:34 PDT 
(In reply to Tim Horton from comment #8)
> Comment on attachment 402571 [details]
> patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=402571&action=review
> 
> > Source/WTF/wtf/TranslatedProcess.cpp:33
> > +#include <wtf/DataLog.h>
> 
> Why's this?

It was testing. Will remove
Comment 10 Saam Barati 2020-06-23 11:15:47 PDT 
Created attachment 402572 [details]
patch for landing
Comment 11 EWS 2020-06-23 13:11:41 PDT 
Committed r263415: <https://trac.webkit.org/changeset/263415>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402572 [details].
Comment 12 Radar WebKit Bug Importer 2020-06-23 13:12:39 PDT 
<rdar://problem/64660056>