Bug 213386 - [GTK] fast/images/low-memory-decode.html is timing out
Summary: [GTK] fast/images/low-memory-decode.html is timing out
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-19 10:06 PDT by Diego Pino
Modified: 2022-11-14 02:02 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-06-19 10:06:56 PDT 
Unexpected flakiness: text-only failures (1)
  fast/images/low-memory-decode.html [ Failure Timeout Pass ]

It seems the test has been flaky since a long time ago.

Diff: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r263263%20(14157)/fast/images/low-memory-decode-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-actual.txt
@@ -1,2 +1,2 @@
-Image decode count: 1
+Image decode count: 2
Comment 1 Diego Pino 2021-06-09 01:43:50 PDT 
This test is constantly timing out:

https://build.webkit.org/results/GTK-Linux-64-bit-Release-Tests/r278650%20%282224%29/fast/images/low-memory-decode-diff.txt

--- /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-expected.txt
+++ /home/buildbot/worker/gtk-linux-64-release-tests/build/layout-test-results/fast/images/low-memory-decode-actual.txt
@@ -1,2 +1,2 @@
-Image decode count: 1
+FAIL: Timed out waiting for notifyDone to be called
 

Gardened in r278654.
Comment 2 Claudio Saavedra 2022-11-09 22:32:54 PST 
I see the test is now crashing instead of timing out in the GTK bots. However, for me it's timing out locally. The reason for the timeout is that tryFinish() does not always call testRunner.notifyDone(), so the test is forever waiting for it. IMO the test should always call test.runnerNotifyDone() and internals.endSimulatedMemoryPressure(), regardless of whether the image was decoded correctly or not. So I will fix that in a separate bug (because the test is still failing after fixing that).
Comment 3 Claudio Saavedra 2022-11-14 02:02:29 PST 
The crash was fixed with https://bugs.webkit.org/show_bug.cgi?id=247727 but the test still timeouts in GTK. Confirmed with Antti that the test is correct, I made the wrong assumption earlire.