Bug 213280 - Web Inspector: Console: add comments for localized strings in execution context picker
Summary: Web Inspector: Console: add comments for localized strings in execution conte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-16 18:47 PDT by Devin Rousso
Modified: 2020-06-18 13:12 PDT (History)
5 users (show)

See Also:

Attachments
Patch (3.66 KB, patch)
2020-06-16 18:59 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-16 18:47:54 PDT 
.
Comment 1 Devin Rousso 2020-06-16 18:59:28 PDT 
Created attachment 402070 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2020-06-16 19:18:13 PDT 
<rdar://problem/64431737>
Comment 3 Joseph Pecoraro 2020-06-18 13:01:14 PDT 
Comment on attachment 402070 [details]
Patch

r=me
Comment 4 BJ Burg 2020-06-18 13:03:56 PDT 
Comment on attachment 402070 [details]
Patch

rs=me

We should clarify the style for localization disambiguation is to use '@'. I am more used to using '(explanation)', but all I seek is consistency.
Comment 5 EWS 2020-06-18 13:12:52 PDT 
Committed r263225: <https://trac.webkit.org/changeset/263225>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402070 [details].