Bug 213273 - REGRESSION (r250866): update-webkit-localizable-strings fails with "mismatched quotes" errors
Summary: REGRESSION (r250866): update-webkit-localizable-strings fails with "mismatche...
Status: RESOLVED DUPLICATE of bug 213274
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 195088
Blocks:
  Show dependency tree / graph
 
Reported: 2020-06-16 17:03 PDT by Andy Estes
Modified: 2020-06-16 17:06 PDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andy Estes 2020-06-16 17:03:54 PDT 
Starting in r250866, update-webkit-localizable-strings fails with the following errors:

> % Tools/Scripts/update-webkit-localizable-strings
> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:929: mismatched quotes
> Source/WebKit/NetworkProcess/Classifier/ResourceLoadStatisticsDatabaseStore.cpp:946: mismatched quotes
> 577 localizable strings
> 41665 strings not marked for localization
> Errors encountered. Exiting without writing to Source/WebCore/en.lproj/Localizable.strings.

Looks like this is due to the use of the R"" literal in joinSubStatisticsForSorting(). Since raw string literals are a new feature in C++11, we probably need to teach extract-localizable-strings.pl how to handle them.
Comment 1 Andy Estes 2020-06-16 17:06:47 PDT 

*** This bug has been marked as a duplicate of bug 213274 ***