Bug 213234 - Web Inspector: Sources: objects in Scope Chain panel flicker when resizing details sidebar
Summary: Web Inspector: Sources: objects in Scope Chain panel flicker when resizing de...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Devin Rousso
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-15 22:00 PDT by Devin Rousso
Modified: 2020-06-16 14:11 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2020-06-15 22:02 PDT, Devin Rousso 		ddkilzer: review+
Details | Formatted Diff | Diff
Patch (1.77 KB, patch)
2020-06-16 13:46 PDT, Devin Rousso 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Devin Rousso 2020-06-15 22:00:17 PDT 
# STEPS TO REPRODUCE
1. inspect any page
2. set a JavaScript breakpoint
3. trigger the breakpoint from step #2
4. select the Scope Chain panel in the details sidebar
5. resize the details sidebar
 => objects in the Scope Chain panel flicker
Comment 1 Devin Rousso 2020-06-15 22:00:34 PDT 
<rdar://problem/64391213>
Comment 2 Devin Rousso 2020-06-15 22:02:31 PDT 
Created attachment 401981 [details]
Patch
Comment 3 David Kilzer (:ddkilzer) 2020-06-16 12:08:34 PDT 
Comment on attachment 401981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401981&action=review

> Source/WebInspectorUI/ChangeLog:12
> +        Don't regenerate the DOM if the `layout` unless the reason is `WI.View.LayoutReason.Dirty`,
> +        such as if the current call frame changes or a watch expression is added/updated/removed.

"Don't regenerate the DOM if the `layout`..." does what?  (Sentence doesn't read properly.)
Comment 4 Devin Rousso 2020-06-16 13:38:35 PDT 
Comment on attachment 401981 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401981&action=review

>> Source/WebInspectorUI/ChangeLog:12
>> +        such as if the current call frame changes or a watch expression is added/updated/removed.
> 
> "Don't regenerate the DOM if the `layout`..." does what?  (Sentence doesn't read properly.)

Oh oops I meant "Don't regenerate the DOM in `layout` unless ..." 😅
Comment 5 Devin Rousso 2020-06-16 13:46:36 PDT 
Created attachment 402035 [details]
Patch
Comment 6 EWS 2020-06-16 14:11:29 PDT 
Committed r263115: <https://trac.webkit.org/changeset/263115>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 402035 [details].