Bug 213125 - Pass parent style to style resolver via animation code
Summary: Pass parent style to style resolver via animation code
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-12 07:28 PDT by Antti Koivisto
Modified: 2023-05-10 12:10 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2020-06-12 07:28:09 PDT 
See TreeResolver::createAnimatedElementUpdate:

// FIXME: Remove this hack and pass the parent style via updateCSSAnimationsForElement.
scope().resolver.setParentElementStyleForKeyframes(&parent().style);
Comment 1 Antti Koivisto 2020-06-12 07:30:00 PDT 
updateCSSAnimationsForElement etc. arguments should probably be factored into a struct so these sort of things can be changed without touching million places.
Comment 2 Radar WebKit Bug Importer 2020-06-12 07:31:03 PDT 
<rdar://problem/64296488>
Comment 3 Antoine Quint 2023-05-10 12:10:55 PDT 
I don't see this code anymore, I believe this was done at some point.