Bug 213107 - timestampOffset doesn't subtract presentationTimestamp from m_groupStartTimestamp
Summary: timestampOffset doesn't subtract presentationTimestamp from m_groupStartTimes...
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-11 19:02 PDT by Yuki Sekiguchi
Modified: 2023-03-24 15:51 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Yuki Sekiguchi 2020-06-11 19:02:07 PDT
Media Source spec defines

https://www.w3.org/TR/media-source/#sourcebuffer-coded-frame-processing
> 1.3.1 Set timestampOffset equal to group start timestamp - presentation timestamp.

The comment matches to the spec, but the code is different from the spec and the comment
https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/Modules/mediasource/SourceBuffer.cpp?rev=%09262766#L1485
> 1485	            // 1.3.1 Set timestampOffset equal to group start timestamp - presentation timestamp.
> 1486	            m_timestampOffset = m_groupStartTimestamp;

I couldn't create a content which reproduce this bug. Sorry.
Comment 1 Radar WebKit Bug Importer 2022-07-01 11:25:57 PDT
<rdar://problem/96304755>
Comment 3 Yuki Sekiguchi 2023-03-22 23:54:24 PDT
Thank you for the information!