Bug 213084 - Replace uses of black/white list with block/allow list
Summary: Replace uses of black/white list with block/allow list
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks: 213092
  Show dependency tree / graph
 
Reported: 2020-06-11 11:05 PDT by Saam Barati
Modified: 2020-07-15 12:46 PDT (History)
18 users (show)

See Also:

Attachments
patch (35.16 KB, patch)
2020-06-11 11:18 PDT, Saam Barati 		keith_miller: review+
Details | Formatted Diff | Diff
patch for landing (37.79 KB, patch)
2020-06-11 12:31 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2020-06-11 11:05:05 PDT 
...
Comment 1 Keith Miller 2020-06-11 11:13:32 PDT 
Less important than just making the change but exclude/include might fit better too, depending on the context.
Comment 2 Saam Barati 2020-06-11 11:18:19 PDT 
Created attachment 401659 [details]
patch
Comment 3 Keith Miller 2020-06-11 11:19:01 PDT 
Comment on attachment 401659 [details]
patch

r=me.
Comment 4 EWS Watchlist 2020-06-11 11:19:16 PDT 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 5 Mark Lam 2020-06-11 11:23:39 PDT 
Comment on attachment 401659 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review

> Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134
> +        allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE)

Capitalize the L to be consistent with how we do it elsewhere?

> Source/JavaScriptCore/tools/FunctionAllowList.cpp:2
> + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved.

Just use "2014-2020" instead.

> Source/JavaScriptCore/tools/FunctionAllowList.h:2
> + * Copyright (C) 2014, 2016, 2020 Apple Inc. All rights reserved.

Ditto.
Comment 6 Saam Barati 2020-06-11 11:31:39 PDT 
Comment on attachment 401659 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review

>> Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:134
>> +        allowlist = set(ObjCGenerator.DOMAINS_TO_GENERATE)
> 
> Capitalize the L to be consistent with how we do it elsewhere?

I should probably do
allow_list to be consistent in this file.
Comment 7 Ross Kirsling 2020-06-11 11:35:37 PDT 
Comment on attachment 401659 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review

Personally I'd vote for a lowercase "l", but whichever works.

> Source/JavaScriptCore/tools/FunctionAllowList.h:35
> +class FunctionWhitelist {

Seems like this file got renamed but its contents weren't updated?
Comment 8 Saam Barati 2020-06-11 11:40:53 PDT 
Comment on attachment 401659 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401659&action=review

>> Source/JavaScriptCore/tools/FunctionAllowList.h:35
>> +class FunctionAllowList {
> 
> Seems like this file got renamed but its contents weren't updated?

This is just bugzilla showing diff in two parts I believe
Comment 9 Saam Barati 2020-06-11 12:31:28 PDT 
Created attachment 401669 [details]
patch for landing
Comment 10 EWS 2020-06-11 15:47:26 PDT 
Committed r262928: <https://trac.webkit.org/changeset/262928>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401669 [details].
Comment 11 Radar WebKit Bug Importer 2020-06-11 15:48:18 PDT 
<rdar://problem/64273619>
Comment 12 Filip Pizlo 2020-07-15 12:46:56 PDT 
R=me too.