Bug 213072 - Add dependencies for Migrate Headers and Generate Export Files build phases
Summary: Add dependencies for Migrate Headers and Generate Export Files build phases
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
URL:
Keywords: InRadar
Depends on:
Blocks: 213067
  Show dependency tree / graph
 
Reported: 2020-06-11 04:03 PDT by Keith Rollin
Modified: 2020-06-12 00:01 PDT (History)
2 users (show)

See Also:

Attachments
Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers. (4.03 KB, patch)
2020-06-11 04:06 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Patch (5.12 KB, patch)
2020-06-11 22:44 PDT, Keith Rollin 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-06-11 04:03:15 PDT 
These build phases have incomplete specifications for the files they consume and produce, which can lead to incorrect builds.
Comment 1 Radar WebKit Bug Importer 2020-06-11 04:03:32 PDT 
<rdar://problem/64249345>
Comment 2 Keith Rollin 2020-06-11 04:06:23 PDT 
Created attachment 401631 [details]
Uploading for reference; the work is incomplete -- still needs dependencies for Migrate Headers.
Comment 3 Keith Rollin 2020-06-11 22:44:33 PDT 
Created attachment 401710 [details]
Patch
Comment 4 Keith Rollin 2020-06-11 22:47:55 PDT 
I tested this by performing full and then incremental NULL builds with XCBuild on and off. I then applied the patch from Bug 213067 and performed two incremental builds. I checked the build output of each build to verify that the desired build steps were being performed. Most importantly, the build failure discovered in Bug 213067 was gone.
Comment 5 Tim Horton 2020-06-11 23:18:44 PDT 
Thanks, Keith!
Comment 6 EWS 2020-06-12 00:01:41 PDT 
Committed r262935: <https://trac.webkit.org/changeset/262935>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401710 [details].