Bug 213046 - Improve url-setters.html WPT test
Summary: Improve url-setters.html WPT test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-10 13:21 PDT by Rob Buis
Modified: 2020-06-11 05:45 PDT (History)
7 users (show)

See Also:

Attachments
Patch (16.16 KB, patch)
2020-06-10 13:22 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (16.54 KB, patch)
2020-06-11 00:20 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (16.11 KB, patch)
2020-06-11 01:55 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-06-10 13:21:08 PDT 
Improve url-setters.html WPT test by testing for failure that can occur
when setting host or hostname [1].

[1] https://url.spec.whatwg.org/#host-state
Comment 1 Rob Buis 2020-06-10 13:22:52 PDT 
Created attachment 401575 [details]
Patch
Comment 2 Darin Adler 2020-06-10 14:53:01 PDT 
Comment on attachment 401575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401575&action=review

> Source/WebCore/html/URLDecomposition.cpp:128
> +    if (fullURL.isValid())
> +        setFullURL(fullURL);

Can we put this check inside the setFullURL function? Does something fail if we do that?
Comment 3 Rob Buis 2020-06-11 00:20:40 PDT 
Created attachment 401625 [details]
Patch
Comment 4 Rob Buis 2020-06-11 01:55:04 PDT 
Created attachment 401628 [details]
Patch
Comment 5 EWS 2020-06-11 02:41:38 PDT 
Committed r262900: <https://trac.webkit.org/changeset/262900>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401628 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-11 02:42:19 PDT 
<rdar://problem/64247583>
Comment 7 Rob Buis 2020-06-11 05:45:53 PDT 
Comment on attachment 401575 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401575&action=review

>> Source/WebCore/html/URLDecomposition.cpp:128
>> +        setFullURL(fullURL);
> 
> Can we put this check inside the setFullURL function? Does something fail if we do that?

I tried, but it breaks one test. I propose we add these checks as needed.