Bug 212950 - [WebDriver][WPE] Support creating new webviews from create-web-view signal
Summary: [WebDriver][WPE] Support creating new webviews from create-web-view signal
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WPE WebKit (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: BrowserCompat
Depends on:
Blocks: wpe-webdriver
  Show dependency tree / graph
 
Reported: 2020-06-08 20:21 PDT by Lauro Moura
Modified: 2024-07-01 07:12 PDT (History)
9 users (show)

See Also:

Attachments
WIP without touch and cleanup support (40.95 KB, patch)
2020-10-28 23:15 PDT, Lauro Moura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-06-08 20:21:03 PDT 
Originally, bug 212118 was created to allow MB to create new views for some WebDriver tests from the "create" signal in child views, and fixed a number of failures.

But "POST /session/{session_id}/window/new" implementation emits "create-web-view". WPE's MiniBrowser handler for it only returns the original automated webview instead of creating a new one.

This is is causing a number of w3c/tests/new_window/user_prompts.py to fail.
Comment 1 Lauro Moura 2020-10-28 23:15:08 PDT 
Created attachment 412615 [details]
WIP without touch and cleanup support

With this patch, a lot of new WebDriver failures related to the session fixure from W3C tests are working now. Still missing touch support, styling changes and sorting out the cleanup, but uploading for initial feedback.
Comment 2 Lauro Moura 2024-06-23 21:34:57 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30103
Comment 3 EWS 2024-07-01 07:12:47 PDT 
Committed 280534@main (474a4428f7ed): <https://commits.webkit.org/280534@main>

Reviewed commits have been landed. Closing PR #30103 and removing active labels.