Bug 212947 - [Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT
Summary: [Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Text (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 19:13 PDT by Fujii Hironori
Modified: 2020-06-09 12:55 PDT (History)
7 users (show)

See Also:

Attachments
Patch (2.43 KB, patch)
2020-06-08 19:25 PDT, Fujii Hironori 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2020-06-08 19:13:36 PDT 
[Win] ComplexTextControllerUniscribe: Retry ScriptShape with SCRIPT_UNDEFINED if it failed as USP_E_SCRIPT_NOT_IN_FONT

Displaying Text with Uniscribe
https://docs.microsoft.com/en-us/windows/win32/intl/displaying-text-with-uniscribe

> 7. If ScriptShape returns the code USP_E_SCRIPT_NOT_IN_FONT or
> S_OK with the output containing missing glyphs, select characters
> from a different font. Either substitute another font or disable
> shaping by setting the eScript member of the SCRIPT_ANALYSIS
> structure passed to ScriptShape to SCRIPT_UNDEFINED. For more
> information, see Using Font Fallback.
Comment 1 Fujii Hironori 2020-06-08 19:25:58 PDT 
Created attachment 401410 [details]
Patch
Comment 2 Fujii Hironori 2020-06-08 19:27:21 PDT 
It's easy to test this issue by opening a Tibetan page at the
moment because there is another bug in fallback font selection
for Tibetan characters (Bug 212688). However, if the bug is
fixed, I don't know how can this issue be tested.
Comment 3 Fujii Hironori 2020-06-09 12:54:22 PDT 
Comment on attachment 401410 [details]
Patch

Clearing flags on attachment: 401410

Committed r262804: <https://trac.webkit.org/changeset/262804>
Comment 4 Fujii Hironori 2020-06-09 12:54:25 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Radar WebKit Bug Importer 2020-06-09 12:55:18 PDT 
<rdar://problem/64175943>
Comment 6 Radar WebKit Bug Importer 2020-06-09 12:55:20 PDT 
<rdar://problem/64175945>