Bug 212942 - WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS
Summary: WebKitLegacy: Exclude NSURLConnectionSPI.h from watchOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 17:16 PDT by Jonathan Bedard
Modified: 2020-07-06 13:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.39 KB, patch)
2020-06-08 17:21 PDT, Jonathan Bedard 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-06-08 17:16:45 PDT 
NSURLConnectionSPI.h is not needed to build watchOS.
Comment 1 Radar WebKit Bug Importer 2020-06-08 17:17:22 PDT 
<rdar://problem/64141877>
Comment 2 Jonathan Bedard 2020-06-08 17:21:30 PDT 
Created attachment 401402 [details]
Patch
Comment 3 EWS 2020-06-08 20:24:38 PDT 
Committed r262764: <https://trac.webkit.org/changeset/262764>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401402 [details].
Comment 4 Wenson Hsieh 2020-07-01 10:07:23 PDT 
Comment on attachment 401402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review

> Source/WebKitLegacy/mac/Misc/WebDownload.h:36
> +#import <pal/spi/cocoa/NSURLConnectionSPI.h>

Hm...is it safe to import PAL headers like this?

I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients...
Comment 5 Jonathan Bedard 2020-07-06 13:33:30 PDT 
Comment on attachment 401402 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401402&action=review

>> Source/WebKitLegacy/mac/Misc/WebDownload.h:36
>> +#import <pal/spi/cocoa/NSURLConnectionSPI.h>
> 
> Hm...is it safe to import PAL headers like this?
> 
> I don't think PAL headers were intended to be imported by clients outside of WebKit, since they use WTF macros like USE(). However, this is an SPI header that could (in theory) be imported by any internal Apple clients...

I think your right. Verifying locally right now that we don't need this, I think I just needed to change the define guard.