Bug 212928 - TextManipulation should only convert text from Node's text content to tokens
Summary: TextManipulation should only convert text from Node's text content to tokens
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 15:32 PDT by Sihui Liu
Modified: 2020-06-08 23:55 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.20 KB, patch)
2020-06-08 15:50 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch (15.39 KB, patch)
2020-06-08 18:55 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (15.38 KB, patch)
2020-06-08 23:29 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2020-06-08 15:32:16 PDT 
...
Comment 1 Sihui Liu 2020-06-08 15:50:22 PDT 
Created attachment 401386 [details]
Patch
Comment 2 Sihui Liu 2020-06-08 18:55:22 PDT 
Created attachment 401408 [details]
Patch
Comment 3 Wenson Hsieh 2020-06-08 20:24:09 PDT 
Comment on attachment 401408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401408&action=review

> Source/WebCore/editing/TextManipulationController.cpp:234
> +                if (contiansDelimiter) {

Nit - contiansDelimiter => containsDelimiter

> Source/WebCore/editing/TextManipulationController.cpp:329
> +TextManipulationController::ManipulationUnit TextManipulationController::createUnit(const Vector<String>& text, Node* textNode)

Maybe make this take `Node& textNode`, since we never expect it to be null?
Comment 4 Sihui Liu 2020-06-08 23:29:56 PDT 
Created attachment 401419 [details]
Patch for landing
Comment 5 EWS 2020-06-08 23:54:25 PDT 
Committed r262778: <https://trac.webkit.org/changeset/262778>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401419 [details].
Comment 6 Radar WebKit Bug Importer 2020-06-08 23:55:16 PDT 
<rdar://problem/64152411>