We need to import a few tests from the WPT repository to cover some cases related to how baseline alignment may affect the grid's intrinsic size computation. These tests are needed to cover some of the changes to fix bug #209282
These tests has been merged in the PR https://github.com/web-platform-tests/wpt/pull/24022
Created attachment 401382 [details] Patch
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment on attachment 401382 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=401382&action=review > LayoutTests/TestExpectations:1070 > +webkit.org/b/209282 imported/w3c/web-platform-tests/css/css-grid/layout-algorithm/baseline-alignment-affects-intrinsic-size-001.html [ Failure ] I don't understand why you mark them as Failure. They have a -expected.txt file, so it won't need to be marked like that. And also the -expected file has all PASS.
Created attachment 401427 [details] Patch Change expectations to reflect the test cases failing
Comment on attachment 401427 [details] Patch r=me, but the corresponding w3c-import.log file should be updated too.
Also wait for green EWSs before landing.
Created attachment 401431 [details] Patch Tests pass on mac platform, so reflect that in the test expectations
Created attachment 401432 [details] Patch Fixed text expectations
Comment on attachment 401432 [details] Patch The failures in the mac-debug-wk1 seems unrelated to this change, so landing.
Committed r262788: <https://trac.webkit.org/changeset/262788> All reviewed patches have been landed. Closing bug and clearing flags on attachment 401432 [details].
<rdar://problem/64160279>