Bug 212917 - Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
Summary: Extended Color: Rename Color::lighten() and Color::darken() to Color::lighten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-06-08 13:24 PDT by Sam Weinig
Modified: 2020-06-08 17:11 PDT (History)
8 users (show)

See Also:

Attachments
Patch (6.85 KB, patch)
2020-06-08 13:31 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (7.31 KB, patch)
2020-06-08 16:06 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (6.86 KB, patch)
2020-06-08 16:12 PDT, Sam Weinig 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2020-06-08 13:24:07 PDT 
Extended Color: Rename Color::lighten() and Color::darken() to Color::lightened() and Color::darkened()
Comment 1 Sam Weinig 2020-06-08 13:31:28 PDT 
Created attachment 401365 [details]
Patch
Comment 2 EWS 2020-06-08 14:35:57 PDT 
Tools/Scripts/svn-apply failed to apply attachment 401365 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 3 Sam Weinig 2020-06-08 16:06:32 PDT 
Created attachment 401391 [details]
Patch
Comment 4 EWS 2020-06-08 16:08:31 PDT 
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Comment 5 Sam Weinig 2020-06-08 16:12:24 PDT 
Created attachment 401393 [details]
Patch
Comment 6 Darin Adler 2020-06-08 16:30:30 PDT 
Comment on attachment 401393 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401393&action=review

> Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222
> +    auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy();

typo in existing code: "ligtened"
Comment 7 Sam Weinig 2020-06-08 16:40:22 PDT 
(In reply to Darin Adler from comment #6)
> Comment on attachment 401393 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=401393&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebCore/ColorTests.cpp:222
> > +    auto cLigtened = Color(c).lightened().toSRGBASimpleColorLossy();
> 
> typo in existing code: "ligtened"

Gaaaaa :). I'll get it right one of these times.
Comment 8 EWS 2020-06-08 17:11:00 PDT 
Committed r262753: <https://trac.webkit.org/changeset/262753>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401393 [details].
Comment 9 Radar WebKit Bug Importer 2020-06-08 17:11:18 PDT 
<rdar://problem/64141679>