Created attachment 401285 [details]
Patch

Comment on attachment 401285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401285&action=review

> Source/WebCore/layout/FormattingContextGeometry.cpp:120
> -        return width;
> +        return style.logicalWidth();

Probably don't need this return since all paths of the switch return.

Comment on attachment 401285 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=401285&action=review

>> Source/WebCore/layout/FormattingContextGeometry.cpp:120
>> +        return style.logicalWidth();
> 
> Probably don't need this return since all paths of the switch return.

Actually, it is better to not have a default in the switch and instead have ASSERT_NOT_REACHED() here. That way if the enum ever gain another member the compiler will force handling that case.

Created attachment 401291 [details]
Patch

Committed r262698: <https://trac.webkit.org/changeset/262698>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 401291 [details].

<rdar://problem/64089714>